Jump to content
Sign in to follow this  
jackocleebrown

Musicbrainz Picard Tagger DSF support

Recommended Posts

Hello,

 

I have written a plugin to add support for the DSF audio format to the Musicbrainz Picard Tagger (which is my favorite).

 

The plugin seems to work on the few files I've tested. If you would like to beta test then please download here:

https://dsf2flac.googlecode.com/svn/trunk/extras/picard%20dsf%20file%20support/picard%20plugin%20-%20dsf%20file%20support.zip

 

All the best, Jack.

Share this post


Link to post
Share on other sites

Hi Jack,

thanks for plugin. I was looking for a Picard plugin in order to update dsd file tags.

It works as intended, most of my collection is updated now.

MPD (0.18-git) recognize the tags but foobar (foobar v 1.2.4 beta 3 and Super Audio CD v 0.6.2) does not :). I presume that is because of how foobar/sacd plugin is reading the tags. For me is not a problem as I use mostly mpd.

 

Catalin

Share this post


Link to post
Share on other sites
Hi Jack,

thanks for plugin. I was looking for a Picard plugin in order to update dsd file tags.

It works as intended, most of my collection is updated now.

MPD (0.18-git) recognize the tags but foobar (foobar v 1.2.4 beta 3 and Super Audio CD v 0.6.2) does not :). I presume that is because of how foobar/sacd plugin is reading the tags. For me is not a problem as I use mostly mpd.

 

Catalin

 

Glad it worked for you! I would guess that if the new tags are coming up on MPD but not foobar then foobar must not be reading the ID3 metadata from the file. It might just be using the filename to guess the tags.

 

All the best, Jack.

Share this post


Link to post
Share on other sites
Glad it worked for you! I would guess that if the new tags are coming up on MPD but not foobar then foobar must not be reading the ID3 metadata from the file. It might just be using the filename to guess the tags.

 

All the best, Jack.

 

Hi Jack, thanks for the effort on the DSF plugin! I tried the program the other day and no doubt the text tagging capability is fantastic but I think the album art portion is not implemented yet or am I not using it correctly?

Share this post


Link to post
Share on other sites
Hi Jack, thanks for the effort on the DSF plugin! I tried the program the other day and no doubt the text tagging capability is fantastic but I think the album art portion is not implemented yet or am I not using it correctly?

 

Hello!

 

Glad it has been useful for you.

 

I have to confess that I've not tested the embeded album art feature. The part of the code which actually writes the tags is taken from the code that picard uses for MP3 files so, assuming embeded art works on MP3s, I don't see why it would not work. I'll have a look and try and figure out what is happening. I presume that you have the "embed album art" enabled in the tagger options?

 

Best regards, Jack.

Share this post


Link to post
Share on other sites
Hello!

 

Glad it has been useful for you.

 

I have to confess that I've not tested the embeded album art feature. The part of the code which actually writes the tags is taken from the code that picard uses for MP3 files so, assuming embeded art works on MP3s, I don't see why it would not work. I'll have a look and try and figure out what is happening. I presume that you have the "embed album art" enabled in the tagger options?

 

Best regards, Jack.

 

Hi Jack,

 

Yeah, I did check that box that you mentioned but I think the album artwork is a no-go at the moment.

Share this post


Link to post
Share on other sites

Hi,
a lot of time has passed so I'm wondering if that plugin still extists and works.
I tried the link above but... it doesn't exist anymore.
Someone has some news about it?

Thank a lot

Share this post


Link to post
Share on other sites

Hi,

 

The plugin is now hosted at https://github.com/hank/dsf2flac along with the code for DSF2FLAC. I saw your comment that it doesn't work with Picard 1.3.2 on github too.

 

My audio system at home can't replay DSF directly so instead I convert them to FLAC (using DSF2FLAC). This means I don't have any need for tagging DSF files and also means that I haven't maintained the plugin to work the with latest versions of Picard.

 

Kind regards,

Jack.

 

 

 

 

 

Share this post


Link to post
Share on other sites
28 minutes ago, jackocleebrown said:

Agh! What a bad choice! o.O
Why did not you keep your original DSF files and did not let the media server convert from DSD to PCM?
I know the DSD to PCM conversion is not a trivial job and there's a serious risk to loose the original information (let's say: a DSD-PCM-DSD conversion lead to a different DSD information if compared to the original DSD).
Every music server I use (LMS, Daphile, Synology native, etc...) has an on line DSD to PCM conversion plugin, so no worry about the DSD DAC compliance, instead preserve your original digital signal!
All this, obviously, imho...

Cheers
EJ

 

 

Share this post


Link to post
Share on other sites
41 minutes ago, jackocleebrown said:

Hi,

Just remembered that there was another github contributor who has updated the plugin to work with Picard  1.4.2.

 

Looks like you can download here: https://github.com/aidan-g/dsf2flac/raw/master/extras/picard dsf file support/picard plugin - dsf file support.zip

 

Kind regards,

Jack.

 

Yes, I saw that plug-in.
Unfortunately it does not collect the information from MusicBrainz (specific ID, ASIN, etc.). It looks like the plug-in only identifies the album and titles using the file name but it can save any ID3v tag.

EJ

Share this post


Link to post
Share on other sites
39 minutes ago, erwjack said:

Agh! What a bad choice! o.O
Why did not you keep your original DSF files...

 

Of course I kept the original DSF files ¬¬.

 

40 minutes ago, erwjack said:

....and did not let the media server convert from DSD to PCM

 

That might be true now but it was not always so. The whole reason I wrote DSF2FLAC was because I wanted to ensure the conversion was done well. The DSF plugin for Picard was just a by-product of writing DSF2FLAC.

 

 

 

 

Share this post


Link to post
Share on other sites
8 minutes ago, erwjack said:

 

Yes, I saw that plug-in.
Unfortunately it does not collect the information from MusicBrainz (specific ID, ASIN, etc.). It looks like the plug-in only identifies the album and titles using the file name but it can save any ID3v tag.

EJ

 

It is the same plugin that I wrote, just updated for version 1.4.2. If you mean that audio fingerprinting won't work then that is correct. But does allow you to write the full MB tags to DSF files. You need to manually select the correct files from the MB database (Lookup in browser). You only need to do this once and then MB will automatically identify next time from the written tags.

 

 

Share this post


Link to post
Share on other sites

Yep, I tried but it doesn't work. I looked up in browser and tagged the right release. Picard shown at right the release with all empty tracks.
I dragged each file at the right position and I saved all (right mouse button on the release and "Save").
MP3Tag doesn't see any tag, all files are tag-empty. :-(

 

EJ

Share this post


Link to post
Share on other sites

Just tested myself with Picard 1.4.2 and the plugin from the link above. For me Picard is definitely writing tags. First I tag a file using "Lookup in Browser", then drag the file to the right position, then save. Then "remove" the release and load the file again. Picard knows which release it is from without me having to "Lookup in Browser" and the "Original Value" tag fields are fully populated.

 

However, if I try and read the file in Mp3tag then there is a warning "(!BAD ID3V2)".

 

Loading the same file in another tagging programme (Kid3) I can see the correct Picard tags (see screenshot attached).

 

So there is at least some incompatibility with Mp3tag.

 

Which media player/streaming server do you use? Have you tried the Picard tagged files with that? I previously used LMS and as I recall the tags could be read fine (that would have been on the original plugin and a much older Picard version).

 

 

Screenshot_20171206_224754.png

Share this post


Link to post
Share on other sites
11 hours ago, jackocleebrown said:

Just tested myself with Picard 1.4.2 and the plugin from the link above. For me Picard is definitely writing tags. First I tag a file using "Lookup in Browser", then drag the file to the right position, then save. Then "remove" the release and load the file again. Picard knows which release it is from without me having to "Lookup in Browser" and the "Original Value" tag fields are fully populated.

 

However, if I try and read the file in Mp3tag then there is a warning "(!BAD ID3V2)".

 

Loading the same file in another tagging programme (Kid3) I can see the correct Picard tags (see screenshot attached).

 

So there is at least some incompatibility with Mp3tag.

 

Which media player/streaming server do you use? Have you tried the Picard tagged files with that? I previously used LMS and as I recall the tags could be read fine (that would have been on the original plugin and a much older Picard version).

 

 

Screenshot_20171206_224754.png

 

Hi jacko,
I reinstalled Picard (maybe my installation was broken for some reason) and I confirm what you found in your last test.
Then I used TagScanner to investigate and I think I've found the reasons of the problem.

 

There are two problems:

 

1. Tag "COMMENT WORKPARTS_OPTIONS" not valid
There's a "COMMENT WORKPARTS_OPTIONS" tag (containing a lot of text) on every Picard saved DSF file. I don't know this particular tag but this is the origin of the "(!BAD ID3v2)" error; if you remove this tag all the others come to life in MP3Tag.

 

2. Many specific Musicbrainz tags have a wrong name.
I noted that, even if the above error is resolved, many specific Musicbrainz tags don't appear in MP3Tag where I normally expect to see them.
Examples:
Ther's a tag "MUSIC BRAINZ ALBUM TYPE" with an "album" string wrote by the plugin. But I expect to have a "RELEASETYPE" tag, cause normally (with FLAC files) Picard write a "RELEASETYPE" tag, not the  "MUSIC BRAINZ ALBUM TYPE".
The same appears with the tag "MUSICBRAINZ ALBUM ID", the right name is "MUSICBRAINZ_ALBUMID".
Again, there's no "PUBLISHER" tag but "LABEL" is the right one.
And so on...
You can consult https://picard.musicbrainz.org/docs/tags for more infos.

 

3. (Not a problem, just a correction)

There's a "002_WARNINGS" tag that, in my opinion, it's a wrong tag and it has anytime the value "No works for this track".

I think it's a tag to don't write.

 

So... ehm... maybe you could... :-)
I'm not a Python expert but maybe you, with a bunch of minutes,... :-)

Share this post


Link to post
Share on other sites
On 12/6/2017 at 11:50 PM, jackocleebrown said:

Just tested myself with Picard 1.4.2 and the plugin from the link above. For me Picard is definitely writing tags. First I tag a file using "Lookup in Browser", then drag the file to the right position, then save. Then "remove" the release and load the file again. Picard knows which release it is from without me having to "Lookup in Browser" and the "Original Value" tag fields are fully populated.

 

However, if I try and read the file in Mp3tag then there is a warning "(!BAD ID3V2)".

 

Loading the same file in another tagging programme (Kid3) I can see the correct Picard tags (see screenshot attached).

 

So there is at least some incompatibility with Mp3tag.

 

Which media player/streaming server do you use? Have you tried the Picard tagged files with that? I previously used LMS and as I recall the tags could be read fine (that would have been on the original plugin and a much older Picard version).

 

 

Screenshot_20171206_224754.png

 

Finally I was able to do some quiet trials and I can confirm what was said by Jacko.
To solve the problem of incompatibility with Mp3Tag it is sufficient to make a passage through the save with another tagger that does not have the problem. I discovered, for example, that TagScanner reads the tags written by Picard and it is sufficient to save them (CTRL+A to select all the files, CTRL+S to save them) and the tags are correct and readable also by Mp3Tag.
A bit tortuous but in the end you are sure to have correct tags and no "(!BAD ID3V2)" errors.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
Sign in to follow this  



×
×
  • Create New...